Merged
Conversation
Owner
microbit-rosslowe
commented
Mar 28, 2019
microbit-rosslowe
commented
- Add information on autocomplete to help
- Add screenshot GIFs of the autocomplete process
- Add information on autocomplete to help - Add screenshot GIFs of the autocomplete process
Add note on imports
Collaborator
|
Is this PR ready for review? Has anybody been assigned to review? |
Owner
Author
|
@microbit-carlos We've discussed this in stand-up and Mark has reviewed the copy when adding to a support article. This is ready for a final review in context. |
Owner
Author
|
@microbit-mark Would you be able to review this in the context of help.html (formatting, images, how well the copy flows)? |
|
I think the copy is good. My feeling is that the paragraph probably needs to come under the 'Text window' section though as it's not a menu button feature. |
Owner
Author
|
Change made @microbit-mark, what do you think? |
|
LGTM |
microbit-rosslowe
added a commit
that referenced
this pull request
Jun 10, 2019
* Add autocomplete to help - Add information on autocomplete to help - Add screenshot GIFs of the autocomplete process
microbit-rosslowe
added a commit
that referenced
this pull request
Jun 27, 2019
* Add autocomplete to help - Add information on autocomplete to help - Add screenshot GIFs of the autocomplete process
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.