Merged
Conversation
Contributor
There was a problem hiding this comment.
Pull request overview
This pull request adds pause and clear functionality to both the web UI and TUI (terminal UI) interfaces of sql-tap. The pause feature allows users to temporarily stop receiving new query events while continuing to analyze existing ones, and the clear feature enables users to reset the event list.
Changes:
- Added pause and clear control buttons to the web interface with visual feedback when paused
- Implemented keyboard shortcuts (
pfor pause,ctrl+lfor clear) in the TUI - Added render debouncing with
requestAnimationFrameto optimize web UI performance during rapid updates
Reviewed changes
Copilot reviewed 5 out of 5 changed files in this pull request and generated no comments.
Show a summary per file
| File | Description |
|---|---|
| web/static/style.css | Added CSS styles for control buttons (.ctrl-btn) with hover and active states |
| web/static/index.html | Added pause and clear buttons in a control-group container |
| web/static/app.js | Implemented pause/clear functions, added paused state variable, render debouncing with requestAnimationFrame, and paused indicator in events view |
| tui/model.go | Added paused state field, pause toggle (p key), clear function (ctrl+l), paused indicator in footer, and event filtering when paused |
| tui/list.go | Added paused indicator to title display |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.