Skip to content

PDF UI improvements#64

Merged
mhbuehler merged 1 commit into
mmqna-phase3from
melanie/pdf_ui_improvements
Mar 17, 2025
Merged

PDF UI improvements#64
mhbuehler merged 1 commit into
mmqna-phase3from
melanie/pdf_ui_improvements

Conversation

@mhbuehler
Copy link
Copy Markdown
Owner

@mhbuehler mhbuehler commented Mar 17, 2025

Description

This PR:

  1. Upgrades gradio_pdf to fix an issue with the Q&A pdf component (nonfunctional interactive=False property). Now, uploading from this tab will not be possible, but clearing with the x button still is.

  2. Uses the change event to clear the status textbox when the ingest pdf component is empty. This produces the desired clearing behavior for the status textbox.

Issues

RFC

Type of change

  • Bug fix (non-breaking change which fixes an issue)

Dependencies

Upgrades gradio_pdf from 0.0.19 to 0.0.20

Tests

Manual UI tests

Signed-off-by: Melanie Buehler <melanie.h.buehler@intel.com>
Copy link
Copy Markdown
Collaborator

@dmsuehir dmsuehir left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks

@mhbuehler mhbuehler merged commit 4aa013c into mmqna-phase3 Mar 17, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants