Added TTS validation test#59
Merged
Merged
Conversation
Signed-off-by: okhleif-IL <omar.khleif@intel.com>
dmsuehir
requested changes
Feb 26, 2025
|
|
||
| echo "Build all the images with --no-cache, check docker_image_build.log for details..." | ||
| service_list="multimodalqna multimodalqna-ui embedding-multimodal-bridgetower embedding retriever speecht5 lvm-llava lvm dataprep whisper" | ||
| service_list="multimodalqna multimodalqna-ui embedding-multimodal-bridgetower embedding retriever speecht5-service lvm-llava lvm dataprep whisper" |
Collaborator
There was a problem hiding this comment.
I thought that this service list referred to the labels in the build.yaml: https://github.com/mhbuehler/GenAIExamples/blob/mmqna-phase3/MultimodalQnA/docker_image_build/build.yaml#L68 (Which is labeled as speecht5 without the -service)?
Collaborator
Author
There was a problem hiding this comment.
You're right, I confused this with the container name
Signed-off-by: okhleif-IL <omar.khleif@intel.com>
okhleif-10
changed the title
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Fixed test and Added TTS validation
Issues
List the issue or RFC link this PR is working on. If there is no such link, please mark it as
n/a.Type of change
List the type of change like below. Please delete options that are not relevant.
Dependencies
List the newly introduced 3rd party dependency if exists.
Tests
Ran manually. The megaservice test for modalities will not work unless it uses
mmqna-phase3