Documentation and diagram update for MultimodalQnA phase 3 enhancements#58
Merged
Conversation
Signed-off-by: dmsuehir <dina.s.jones@intel.com>
…o dina/phase3-docs
Signed-off-by: dmsuehir <dina.s.jones@intel.com>
okhleif-10
approved these changes
Feb 20, 2025
Collaborator
okhleif-10
left a comment
There was a problem hiding this comment.
Looks much better and cleaner this way. Diagram makes sense. LGTM
HarshaRamayanam
requested changes
Feb 20, 2025
Signed-off-by: dmsuehir <dina.s.jones@intel.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
This PR updates:
docker_compose.set_env.shfile from a different directory gave an error, so changed it to firstcdto that directory.set_env.shfiles were doing things likeexport http_proxy=${your_http_proxy}, however the main README does not say to setyour_http_proxyas an env var (it says to set the real varhttp_proxy, etc). The README files indocker_composedid mentionyour_no_proxyso I changed those to just beno_proxy. I checked other examples like ChatQnA and theirset_env.shdoes not try to set proxy envs, so hopefully these are fine to remove.Issues
RFC: https://github.com/opea-project/docs/blob/main/community/rfcs/24-10-02-GenAIExamples-001-Image_and_Audio_Support_in_MultimodalQnA.md
Issue: opea-project#1549
Type of change
List the type of change like below. Please delete options that are not relevant.
Dependencies
N/A
Tests
Manually tested README commands