Skip to content

Test and documentation updates for image and audio data ingestion#56

Merged
dmsuehir merged 5 commits into
mmqna-phase3from
dina/audio-captions
Feb 20, 2025
Merged

Test and documentation updates for image and audio data ingestion#56
dmsuehir merged 5 commits into
mmqna-phase3from
dina/audio-captions

Conversation

@dmsuehir
Copy link
Copy Markdown
Collaborator

@dmsuehir dmsuehir commented Feb 15, 2025

Description

This PR has documentation and test updates for image and audio ingestion, which is being added in PR 25.

Issues

RFC: https://github.com/opea-project/docs/blob/main/community/rfcs/24-10-02-GenAIExamples-001-Image_and_Audio_Support_in_MultimodalQnA.md
Issue: opea-project#1549

Type of change

Test and documentation updates

  • Others (enhancement, documentation, validation, etc.)

Dependencies

None

Tests

Added tests for image + audio data prep ingestion.
Ran tests on CLX and Gaudi2 VM.

Signed-off-by: dmsuehir <dina.s.jones@intel.com>
Signed-off-by: dmsuehir <dina.s.jones@intel.com>
Signed-off-by: dmsuehir <dina.s.jones@intel.com>
@dmsuehir dmsuehir requested a review from mhbuehler as a code owner February 15, 2025 00:06
Copy link
Copy Markdown
Collaborator

@HarshaRamayanam HarshaRamayanam left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Copy link
Copy Markdown
Collaborator

@okhleif-10 okhleif-10 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

export audio_fn="sample_audio.mp3"
export caption_fn="apple.txt"
export audio_fn="sample.mp3"
export caption_fn="sample.txt"
Copy link
Copy Markdown
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Are the naming conventions/requirements changing here, or is this just changing to improve consistency?

Copy link
Copy Markdown
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I can add a comment in the code, but these all need to have the same base name in order to use audio as a caption

Signed-off-by: dmsuehir <dina.s.jones@intel.com>
@dmsuehir dmsuehir merged commit f84d52d into mmqna-phase3 Feb 20, 2025
@dmsuehir dmsuehir deleted the dina/audio-captions branch February 20, 2025 22:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants