Skip to content

MMQnA UI option to show/delete files from vector store#52

Merged
mhbuehler merged 5 commits into
mmqna-phase3from
hramayan/vector_store_clear_btn
Feb 10, 2025
Merged

MMQnA UI option to show/delete files from vector store#52
mhbuehler merged 5 commits into
mmqna-phase3from
hramayan/vector_store_clear_btn

Conversation

@HarshaRamayanam
Copy link
Copy Markdown
Collaborator

@HarshaRamayanam HarshaRamayanam commented Feb 4, 2025

Description

Added logic for showing/deleting files from vector store

Issues

opea-project#1549

Type of change

List the type of change like below. Please delete options that are not relevant.

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds new functionality)
  • Breaking change (fix or feature that would break existing design and interface)
  • Others (enhancement, documentation, validation, etc.)

Dependencies

n/a

Tests

Uploaded every possible file type from the UI and successfully deleted them from the UI

HarshaRamayanam and others added 2 commits February 4, 2025 09:43
Signed-off-by: Harsha Ramayanam <harsha.ramayanam@intel.com>
Copy link
Copy Markdown
Collaborator

@dmsuehir dmsuehir left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks, Harsha. I tried it out and it worked for me, I just had a small suggestion.

Comment thread MultimodalQnA/ui/gradio/multimodalqna_ui_gradio.py
Comment thread MultimodalQnA/ui/gradio/multimodalqna_ui_gradio.py Outdated
Co-authored-by: Dina Suehiro Jones <dina.s.jones@intel.com>
Copy link
Copy Markdown
Owner

@mhbuehler mhbuehler left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good, thank you!

Copy link
Copy Markdown
Collaborator

@dmsuehir dmsuehir left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks

Comment thread MultimodalQnA/ui/gradio/multimodalqna_ui_gradio.py
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants