Conversation
ff9b4d6 to
44a55e2
Compare
moroten
left a comment
There was a problem hiding this comment.
Generally good. Just some minor stuff.
| @@ -0,0 +1,294 @@ | |||
| # Plotting memusagestat's data | |||
|
|
|||
| This came up during my preparations for the Bazelcon talk [Dude, where is my RAM?]. | |||
| # Plotting memusagestat's data | ||
|
|
||
| This came up during my preparations for the Bazelcon talk [Dude, where is my RAM?]. | ||
| But the investigation and the graphs produced by `memusagestat` did not make the cut for the talk. |
There was a problem hiding this comment.
Replace ". But" with "but".
| The plot is often nice but there are few options for how to present the data. | ||
| Either by sequential allocation or by linear time, | ||
| and the labels are very small. |
There was a problem hiding this comment.
I understand this as the existence of the options is a good thing and enough, so the only bad thing is that the labels are small. Is that correct?
| So we want to generate new figures for the same data. | ||
|
|
||
| We use `memusage` to profile a `bazel` invocation that runs out of memory |
There was a problem hiding this comment.
| So we want to generate new figures for the same data. | |
| We use `memusage` to profile a `bazel` invocation that runs out of memory | |
| So to generate new figures for the same data, | |
| we use `memusage` to profile a `bazel` invocation that runs out of memory |
| //... | ||
| ``` | ||
|
|
||
| And render a plot |
There was a problem hiding this comment.
| And render a plot | |
| and render a plot |
| Note, the x-axis is the number of allocations, | ||
| when plotted against time the graph instead looks like a noisy square wave. | ||
| Which is interesting in its own right, |
There was a problem hiding this comment.
| Note, the x-axis is the number of allocations, | |
| when plotted against time the graph instead looks like a noisy square wave. | |
| Which is interesting in its own right, | |
| Note that the x-axis is the number of allocations. | |
| When plotted against time the graph instead looks like a noisy square wave, | |
| which is interesting in its own right. |
|
|
||
| ### memusage writes a binary datafile | ||
|
|
||
| Glancing at [the code] it is quite straight forward, |
There was a problem hiding this comment.
| Glancing at [the code] it is quite straight forward, | |
| Glancing at [the code] it is quite straight forward |
| Some file is missing, this error is often raised when the program itself is missing, | ||
| which it is not. | ||
| But some other file is. |
There was a problem hiding this comment.
| Some file is missing, this error is often raised when the program itself is missing, | |
| which it is not. | |
| But some other file is. | |
| Some file is missing. This error is often raised when the program itself is missing, | |
| which it is not, | |
| but some other file is. |
|
|
||
|  | ||
|
|
||
| [available on github]: github.com/meroton/parse-memusagestat/ |
There was a problem hiding this comment.
Bad link. Both relative and non-existing repo.
| Our `memusagestat` parser and plotter is [available on github]. | ||
| And can draw prettier images: |
There was a problem hiding this comment.
| Our `memusagestat` parser and plotter is [available on github]. | |
| And can draw prettier images: | |
| Our `memusagestat` parser and plotter is [available on github] | |
| and can draw prettier images: |
b87719e to
beed912
Compare
meroton-benjamin
left a comment
There was a problem hiding this comment.
General notes, you tend to use so, this and but a lot. Try varying this, you can almost always remove So from the beggining of a sentence.
| for GNU/Linux 3.2.0, with debug_info, not stripped | ||
| ``` | ||
|
|
||
| Aha! This is an interpreted file that wants `ld` to start |
| ### Compile memusagestat | ||
|
|
||
| For good measure we can patch the parsing code in `memusagestat` | ||
| to have oracle data for our parser. |
There was a problem hiding this comment.
When introducing an esoteric concept in a text, such as an oracle, define it or reference it, otherwise the reference will be lost to a significant chunk of the audience
Alternatively use a more common concept (reference data)
|
|
||
| This shows each entry in the binary file, | ||
| heap, stack, lower 32 bits of the time and the higher, | ||
| as well as the joined time within parentheses |
| For good measure we can patch the parsing code in `memusagestat` | ||
| to have oracle data for our parser. | ||
| `memusagestat` comes with `glibc` and can be built with its `make` build system. | ||
| We need to do some preparation, to have all the dynamic libraries work well. |
There was a problem hiding this comment.
In order to have all the dynamic libraries work well we need to do some preparation
|
|
||
| `memusage` is a great tool to track all allocations for a program, | ||
| this comes to many Linux distributions with `glibc` itself. | ||
| So if you need a quick-and-easy allocation tracker `memusage` is the tool for you! |
There was a problem hiding this comment.
Remove initial So
docs/captains-log/index.md
Outdated
| # Captain's Log | ||
|
|
||
| Follow the Captain's Odyssey to the best and fastest builds. | ||
| This salt-stained log is where he documents the fair sights |
There was a problem hiding this comment.
This salt-stained log documents the fair sights...
docs/captains-log/index.md
Outdated
| This salt-stained log is where he documents the fair sights | ||
| and obstacles encountered. | ||
|
|
||
| This contains information about many auxiliary tools and technologies, |
There was a problem hiding this comment.
The log contains....
docs/captains-log/index.md
Outdated
| and obstacles encountered. | ||
|
|
||
| This contains information about many auxiliary tools and technologies, | ||
| and notes on all the moving pieces in the remote execution ecosystem. |
There was a problem hiding this comment.
as well as
(avoid using and as a conjunction between sentances after using it as a list separator right before)
| tags: [linux, glibc, python] | ||
| --- | ||
|
|
||
| `memusage` is a great tool to track all allocations for a program, |
There was a problem hiding this comment.
see comments on first heading in article
| You can read the full document here: [Plotting memusagestat's data]. | ||
| There are two take-home messages: | ||
|
|
||
| * One, is a case-study in building and modifying `glibc` tools for your computer: |
There was a problem hiding this comment.
Either use full sentences (A case study in... and our code that you can leverage to plot...) or an ordered list
- A case study in building and modifying
- Our code to plot allocations
6379c27 to
9cbdc67
Compare
35032a9 to
361ae6d
Compare
361ae6d to
2d4c40f
Compare
No description provided.