Rems118 url change#13
Conversation
auto-assign
Bot
requested review from
KeeyanGhoreshi,
kierk,
smalho01 and
zacharyrobin
| const documentId = req.params.id; | ||
| let documentOrder = await DoctorOrder.findById(documentId); | ||
| const crdUrl = (process.env.CRD_BASE_URL ? process.env.CRD_BASE_URL : "http://localhost:8090/") + "rems/" + documentOrder.caseNumber; | ||
| const crdUrl = (process.env.CRD_BASE_URL ? process.env.CRD_BASE_URL : "http://localhost:8090/") + "api/rems/" + documentOrder.caseNumber; |
There was a problem hiding this comment.
I don't believe there is any endpoint on CRD for api/rems/. It was added in mcode/CRD#18 and changed in mcode/CRD#24, should just be rems/ unless there are plans to revert the endpoint back in CRD.
There was a problem hiding this comment.
I see, I'm not aware of which endpoints are used since I'm new to the team and I haven't been able to test out implementation with postman. I can check in with Sahil about this and make a new request if necessary
| } | ||
|
|
||
| function parseRemsAdminRequest(requestBody , existingDocOrder = undefined) { | ||
| const complianceBundle = requestBody?.resource; |
There was a problem hiding this comment.
change this back to be .resource
| const DoctorOrder = require('../models/doctorOrders'); | ||
|
|
||
| router.patch("/fhir/rems/:id", async (req, res, next) => { | ||
| router.patch("/$process-message/:id", async (req, res, next) => { |
There was a problem hiding this comment.
change this to be ([$])process-message. See expressjs/express#2987 for more context
| }); | ||
|
|
||
| router.patch("/fhir/rems/pickedUp/:id", async (req, res, next) => { | ||
| router.patch("/$process-message/pickedUp/:id", async (req, res, next) => { |
There was a problem hiding this comment.
change this to be ([$])process-message. See expressjs/express#2987 for more context
|
|
||
|
|
||
| router.post("/fhir/rems", (req, res, next) => { | ||
| router.post("/$process-message", (req, res, next) => { |
There was a problem hiding this comment.
change this to be ([$])process-message. See expressjs/express#2987 for more context
3 participants
review this alongside mcode/dtr#27