Stu2/utils updates#156
Merged
Merged
Conversation
julianxcarter
requested changes
Sep 30, 2021
julianxcarter
left a comment
Contributor
There was a problem hiding this comment.
Everything here looks good to me! I've done a sanity check to ensure that the bits you've identified that don't need changes don't in fact need changes, and also that values that do need changes have been changed appropriately. I don't think you've missed anything. I just had one minor comment (about a comment) and I think this is ready to merge.
| @@ -2,7 +2,7 @@ const { createInvertedLookup, createLowercaseLookup } = require('../lookupUtils' | |||
|
|
|||
| // Code mapping is based on current values at http://standardhealthrecord.org/guides/icare/mapping_guidance.html | |||
Contributor
There was a problem hiding this comment.
JC1: I think we should probably update the link in this comment to point to https://www.hl7.org/fhir/us/mcode/2021May/ValueSet-mcode-condition-status-trend-vs.html
Contributor
Author
|
Addressed your feedback @julianxcarter 😄 |
julianxcarter
approved these changes
Oct 1, 2021
julianxcarter
left a comment
Contributor
There was a problem hiding this comment.
Awesome! Looks good to me 👍🏽
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Below are all the major utils-related concepts checked for changes across STU1 to STU2. These lists of questions are based on the responsibilities of the utils files (listed below) identified by the task. Conclusions are based on the May2021 STU2 specification described here: http://hl7.org/fhir/us/mcode/2021May/index.html
Files checked:
Key concepts checked, along with their change/no change status:
89243-089247-1'2135-2': 'Hispanic or Latino', '2186-5': 'Non Hispanic or Latino',mcodeDiseaseStatusCodeToTextLookup260415000 -> 'Not detected (qualifier)', but STU2 updates this null-ish value to be281900007 -> 'No abnormality detected (finding)'. This change will be appliedicareDiseaseStatusCodeToTextLookupevidenceTextToCodeLookupurn:oid:2.16.840.1.113883.6.90PrimaryCancerConditionVStoPrimaryOrUncertainBehaviorCancerDisorderVShappened as a part of the shift from STU1 to STU2, we already referenced the latter VS in our tools. A happy coninscidence 😊Testing guidance
utilsfiles I should inspect 😄