Add content-anchored resolvable comments#16
Open
mblode wants to merge 3 commits into
Open
Conversation
- Revert custom theme-provider → keep next-themes (pre-hydration script, system preference tracking, disableTransitionOnChange) - Fix Copy & Clear data loss: export all comments, not just visible ones - Fix deletion-side anchoring: left-side comments read from merge base ref - Restore min-height pinning in CollapsibleFileDiff for Safari scroll stability - Refresh comments on watch events so staleness stays current - Invalidate comment snapshot cache alongside git cache on file changes Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
mblode
changed the title
|
I just vibed a bunch more changes on top of this today. Code is possibly even more of a mess now but overall it was probably in a better state than the previous pass at it if you want more inspo to cherry pick from edbordin-linktree#1 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Cherry-picks Ed Bordin's two commits from PR #15 onto an upstream branch, with a quality pass on top. Adds content-anchored resolvable comments with reply threads, staleness detection, prev/next navigation, and resolved toggle.
Quality fixes: reverted custom theme-provider back to next-themes (flash-of-wrong-theme), fixed Copy & Clear silently deleting hidden resolved comments, made left-side comment anchoring read from the merge base ref, restored Safari min-height pinning, and wired comment refresh into watch events.
Risk: deletion-side anchoring falls back to working-tree content when git commands fail (e.g. detached HEAD with no merge base).