Skip to content

[argparse] fix incorrect string concatenation for choices #28

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
max-au merged 1 commit into from
Mar 16, 2022
Merged

[argparse] fix incorrect string concatenation for choices #28

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion src/argparse.erl
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1229,7 +1229,7 @@ format_type(#{type := {binary, Re}}) when is_binary(Re) ->
format_type(#{type := {binary, Re, _}}) when is_binary(Re) ->
io_lib:format("binary re: ~ts", [Re]);
format_type(#{type := {StrBin, Choices}}) when StrBin =:= string orelse StrBin =:= binary, is_list(Choices) ->
io_lib:format("choice: ~ts", [lists:join(", ", [Choices])]);
io_lib:format("choice: ~ts", [lists:join(", ", Choices)]);
format_type(#{type := boolean}) ->
"";
format_type(#{type := Type}) when is_atom(Type) ->
Expand Down
2 changes: 1 addition & 1 deletion test/argparse_SUITE.erl
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -711,7 +711,7 @@ usage(Config) when is_list(Config) ->
"\n\nSubcommands:\n crawler controls crawler behaviour\n doze dozes a bit\n\nArguments:\n server server to start\n optpos optional positional (int)"
"\n\nOptional arguments:\n -s initial shards (int)\n -z between (1 < int < 10)\n -l maybe lower (int < 10)"
"\n -m less than 10 (int < 10)\n -b binary with re (binary re: m)\n -g binary with re (binary re: m)\n -t string with re (string re: m)"
"\n ---maybe-req maybe required int (int)\n -y, --yyy string with re (string re: m)\n -u string choices (choice: 12)\n -c tough choice (choice: 1, 2, 3)"
"\n ---maybe-req maybe required int (int)\n -y, --yyy string with re (string re: m)\n -u string choices (choice: 1, 2)\n -c tough choice (choice: 1, 2, 3)"
"\n -q floating choice (choice: 2.10000, 1.20000)\n -foobar foobaring option\n -r recursive\n -f, --force force\n -v verbosity level"
"\n -i interval set (int > 1)\n --req required optional, right?\n --float floating-point long form argument (float, 3.14)\n",
?assertEqual(Usage, argparse:help(Cmd, #{command => ["start"]})),
Expand Down