Skip to content

Update default poetry version to 1.2.0#8

Merged
erikjohnston merged 1 commit into
release/v1from
erikj/update_to_1.2.0
Sep 1, 2022
Merged

Update default poetry version to 1.2.0#8
erikjohnston merged 1 commit into
release/v1from
erikj/update_to_1.2.0

Conversation

@erikjohnston

Copy link
Copy Markdown
Member

Mostly as this will make my life easier for adding in Rust, where in poetry 1.1.* you need to manually upgrade setuptools

Mostly as this will make my life easier for adding in Rust, where in poetry 1.1.* you need to manually upgrade `setuptools`
@erikjohnston erikjohnston requested a review from a team as a code owner August 31, 2022 18:33

@DMRobertson DMRobertson left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Is this a breaking change---are there any backwards incompatabilities between 1.1 and 1.2?

Do you have an example of using this action with 1.2? I'd like to santiy check the logs---in particular that the caching mechanisms still do something useful.

@erikjohnston

Copy link
Copy Markdown
Member Author

Is this a breaking change---are there any backwards incompatabilities between 1.1 and 1.2?

I'm not aware of any, beyond dropping support for 3.6 and below.

Do you have an example of using this action with 1.2? I'd like to santiy check the logs---in particular that the caching mechanisms still do something useful.

matrix-org/synapse#12595 has a lot of runs using 1.2.0 (where I've specifically overriden it).

@DMRobertson

Copy link
Copy Markdown

Thanks. I'm slightly terrified that stuff will break in CI (esp on branches that don't have your Rust PR's changes). But I think we should try it and see what happens.

Can you

@erikjohnston

Copy link
Copy Markdown
Member Author

Thanks. I'm slightly terrified that stuff will break in CI (esp on branches that don't have your Rust PR's changes). But I think we should try it and see what happens.

Yeah, me too. Though I think we're going to have to do it sometime so may as well just bite the bullet.

@erikjohnston erikjohnston merged commit b4b0ae0 into release/v1 Sep 1, 2022
@erikjohnston erikjohnston deleted the erikj/update_to_1.2.0 branch September 1, 2022 08:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants