Skip to content

Only hash ./poetry.lock to compute the cache key for venvs#19

Merged
squahtx merged 1 commit into
release/v1from
squah/tweak_cache_key
Apr 13, 2023
Merged

Only hash ./poetry.lock to compute the cache key for venvs#19
squahtx merged 1 commit into
release/v1from
squah/tweak_cache_key

Conversation

@squahtx

@squahtx squahtx commented Apr 13, 2023

Copy link
Copy Markdown
Contributor

This avoids the post run step failing when a test creates unreadable
files or directories within the working directory.

Signed-off-by: Sean Quah seanq@matrix.org

This avoids the post run step failing when a test creates unreadable
files or directories within the working directory.

Signed-off-by: Sean Quah <seanq@matrix.org>
@squahtx squahtx requested a review from a team as a code owner April 13, 2023 10:43

@DMRobertson DMRobertson left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@squahtx

squahtx commented Apr 13, 2023

Copy link
Copy Markdown
Contributor Author

Thanks! Are you okay to cut a release and move the v1 tag forward?

Sure, I'll do that after I've done some testing.

@squahtx squahtx merged commit 8fe7cb1 into release/v1 Apr 13, 2023
@squahtx squahtx deleted the squah/tweak_cache_key branch April 13, 2023 11:15
@squahtx

squahtx commented Apr 13, 2023

Copy link
Copy Markdown
Contributor Author

Thanks! Are you okay to cut a release and move the v1 tag forward?

Done!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants