Open
Conversation
2 tasks
Member
|
What about merging it now for the release of 1.16.0?
|
Collaborator
Author
|
My reasoning was that if the current master supports 8.20 you may as well do a last release supporting it before dropping it. But if you want to fit #1865 in the release, then it may indded make sense to merge the current PR first. No strong opinion here, in any case the current PR is mergeable so do as you prefer. |
Member
|
Thanks for the information. Then unless somebody figures out a solution I think we'll merge before the release. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Maybe something we want to do after the next release (this will also enable improving the deprecations by using
use=).Cc @affeldt-aist