fix: progress_bar increments past total when range has step > 1#9735
Open
sridhar-3009 wants to merge 2 commits into
Open
fix: progress_bar increments past total when range has step > 1#9735sridhar-3009 wants to merge 2 commits into
sridhar-3009 wants to merge 2 commits into
Conversation
When iterating over range(start, stop, step), len(range) correctly counts the number of iterations, but each loop tick was incrementing current by step instead of 1, causing current to exceed total and produce impossible states (e.g., 10/5). Remove the self.step override for range objects; progress always advances by 1 per iteration, matching the len()-derived total. Fixes marimo-team#9575
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
|
I have read the CLA Document and I hereby sign the CLA You can retrigger this bot by commenting recheck in this Pull Request. Posted by the CLA Assistant Lite bot. |
for more information, see https://pre-commit.ci
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What
mo.status.progress_bar(range(0, 10, 2))reachedcurrent = 10againsttotal = 5, producing an impossible state in the UI.Why
totalis correctly derived fromlen(range)(= 5 iterations), but each loop tick was incrementingcurrentbyrange.step(= 2). After 5 iterations:current = 10 > total = 5.Fix
Remove the
self.step = range.stepoverride. Progress always advances by 1 per iteration, consistent with thelen()-derived total.Test
Added
test_progress_range_with_stepthat assertscurrent == totalafter iterating overrange(0, 10, 2).Fixes #9575