Skip to content

Attempt to skip publish if commit represents a tag #139

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
springmeyer merged 2 commits into from
Jul 14, 2018
Merged

Attempt to skip publish if commit represents a tag #139

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
acb4ecf
attempt to skip publish if commit represents a tag
Jun 14, 2018
9f8fa37
make git describe quiet if it can't find a tag
Jul 14, 2018
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
18 changes: 16 additions & 2 deletions scripts/publish.sh
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -25,6 +25,18 @@ function is_pr_merge() {
fi
}

# Detect if this commit represents a tag. This is useful
# to detect if we are on a travis job that is running due to
# "git tags --push". In this case we don't want to publish even
# if [publish binary] is present since that should refer only to the
# previously job that ran for that commit and not the tag made
function is_tag_commit() {
export COMMIT_MATCHES_KNOWN_TAG=$(git describe --exact-match $(git rev-parse HEAD) 2> /dev/null)
if [[ ${COMMIT_MATCHES_KNOWN_TAG} ]]; then
echo true
fi
}

# `publish` is used to publish binaries to s3 via commit messages if:
# - the commit message includes [publish binary]
# - the commit message includes [republish binary]
Expand All @@ -37,8 +49,10 @@ function publish() {

if [[ $(is_pr_merge) ]]; then
echo "Skipping publishing because this is a PR merge commit"
elif [[ $(is_tag_commit) ]]; then
echo "Skipping publishing because this is a tag"
else
echo "Commit message: ${COMMIT_MESSAGE}"
echo "Commit message was: '${COMMIT_MESSAGE}'"

if [[ ${COMMIT_MESSAGE} =~ "[publish binary]" ]]; then
echo "Publishing"
Expand Down Expand Up @@ -75,4 +89,4 @@ case $i in
esac
done

publish $@
publish $@