Skip to content
This repository was archived by the owner on Aug 8, 2023. It is now read-only.

Explicit conversion#5754

Merged
jfirebaugh merged 4 commits into
masterfrom
explicit-conversion
Jul 22, 2016
Merged

Explicit conversion#5754
jfirebaugh merged 4 commits into
masterfrom
explicit-conversion

Conversation

@GretaCB
Copy link
Copy Markdown
Contributor

@GretaCB GretaCB commented Jul 22, 2016

This PR explicitly handles type conversion, instead of allowing for silent type conversion. This was discovered when @springmeyer noticed that an int was being converted to an bool value incorrectly.

cc @springmeyer @jakepruitt @jfirebaugh

@mention-bot
Copy link
Copy Markdown

@GretaCB, thanks for your PR! By analyzing the annotation information on this pull request, we identified @jfirebaugh and @mikemorris to be potential reviewers

@1ec5 1ec5 added the Core The cross-platform C++ core, aka mbgl label Jul 22, 2016
@GretaCB
Copy link
Copy Markdown
Contributor Author

GretaCB commented Jul 22, 2016

hey @jfirebaugh @mikemorris , this PR is ready to roll as a node fix. After taking a look at CONTRIBUTING.md, do I need to make another commit with [node] in the message?

Curious what else needs to be done before/after merging:

@friedbunny
Copy link
Copy Markdown
Contributor

friedbunny commented Jul 22, 2016

@GretaCB I’m not sure about additional steps for node, but the green button in this repo uses squash-merging and gives you an opportunity to reword/prefix the commit at that time.

@jfirebaugh jfirebaugh merged commit 4b1eead into master Jul 22, 2016
@jfirebaugh jfirebaugh deleted the explicit-conversion branch July 22, 2016 20:05
@mikemorris
Copy link
Copy Markdown
Contributor

the green button in this repo uses squash-merging and gives you an opportunity to reword/prefix the commit at that time

Whoa, I actually had no idea it did that @friedbunny

Thanks for adding this @GretaCB, didn't realize this would be necessary!

@mikemorris mikemorris added the Node.js node-mapbox-gl-native label Jul 25, 2016
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

Core The cross-platform C++ core, aka mbgl Node.js node-mapbox-gl-native

Projects

None yet

Development

Successfully merging this pull request may close these issues.

6 participants