Explicit conversion#5754
Conversation
|
@GretaCB, thanks for your PR! By analyzing the annotation information on this pull request, we identified @jfirebaugh and @mikemorris to be potential reviewers |
|
hey @jfirebaugh @mikemorris , this PR is ready to roll as a node fix. After taking a look at CONTRIBUTING.md, do I need to make another commit with Curious what else needs to be done before/after merging:
|
|
@GretaCB I’m not sure about additional steps for node, but the green button in this repo uses squash-merging and gives you an opportunity to reword/prefix the commit at that time. |
Whoa, I actually had no idea it did that @friedbunny Thanks for adding this @GretaCB, didn't realize this would be necessary! |
This PR explicitly handles type conversion, instead of allowing for silent type conversion. This was discovered when @springmeyer noticed that an
intwas being converted to anboolvalue incorrectly.cc @springmeyer @jakepruitt @jfirebaugh