This repository was archived by the owner on Jun 21, 2023. It is now read-only.
Fix the race condition when updating LocationCompoent's position.#703
Merged
Fix the race condition when updating LocationCompoent's position.#703
Conversation
MapboxGLAndroidSDK/src/main/java/com/mapbox/mapboxsdk/location/SymbolLocationLayerRenderer.java
Outdated
Show resolved
Hide resolved
When using SymbolLayer and GeoJsonSource backed location puck, there's high frequency modifications done on the main thread and locationFeature is always re-used (modified) while being parsed on the worker thread. As the `setGeoJson` method is not thread-safe, we should do a deep copy of the location feature before passing setting it to GeoJsonSource.
pengdev
force-pushed
the
peng-fix-location-component-geojson
branch
from
0e7c16f to
bec190a
Compare
pozdnyakov
approved these changes
Sep 24, 2021
Chaoba
approved these changes
Sep 24, 2021
alexshalamov
approved these changes
Sep 24, 2021
tobrun
approved these changes
Sep 24, 2021
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR fixes the race condition when updating LocationCompoent's position.
This PR also adds documentation to the
GeoJsonSource#setGeoJson, stating the method is not thread-safe.When using SymbolLayer and GeoJsonSource backed location puck, there's high frequency
modifications done on the main thread and locationFeature is always re-used (modified)
while being parsed on the worker thread. As the
GeoJsonSource#setGeoJsonmethod is not thread-safe,we should do a deep copy of the location feature before passing setting it to GeoJsonSource.
<changelog>Fix the race condition when updating LocationCompoent's position.</changelog>