Refactor Django model class names

[jonfroehlich]

When we originally wrote some models like Project_header and Project_umbrella, we didn't follow best naming practices. And it's bothered me ever since. These should be ProjectHeader and ProjectUmbrella respectively.

However, it's not a matter of simply renaming these in code because they are actually table names in PostgreSQL. So, we have to write custom migration code to handle this. Shouldn't be too difficult but will require some work.

[jonfroehlich]

Or I wonder if we could just manually rename the columns in PostgresSQL after changing the model names...

[jonfroehlich]

Looks like Django 2 helps you refactor/rename model names

https://stackoverflow.com/a/26241640

In django 2.0 if you change your model name, the ./manage.py makemigrations myapp command will ask you if you renamed your model. E.g.: Did you rename the myapp.Foo model to Bar? [y/N] If you answer 'y' your migration will contain the migration.RenameModel('Foo', 'Bar') Same counts for the renamed fields :-)

[jonfroehlich]

For best practices, see: https://stackoverflow.com/questions/30255657/best-naming-convention-for-handling-multiword-django-models

[jonfroehlich]

OK, I just did this on my local system and it was painless. I think I'll have to get Jason involved, however, as it requires running migration commands.

(base) jonfroehlich@Jons-MacBook-Pro-2 makeabilitylabwebsite % docker exec -it makeabilitylabwebsite_website_1 bash
apache@31c0a0c7ed35:/code$ python manage.py makemigrations
Was the model website.Project_header renamed to ProjectHeader? [y/N] y
Was the model website.Project_Role renamed to ProjectRole? [y/N] y
Was the model website.Project_umbrella renamed to ProjectUmbrella? [y/N] y
Migrations for 'website':
  website/migrations/0002_rename_project_header_projectheader_and_more.py
    - Rename model Project_header to ProjectHeader
    - Rename model Project_Role to ProjectRole
    - Rename model Project_umbrella to ProjectUmbrella

[jonfroehlich]

This has now been addressed and changes pushed to both -test and production