MAISTRA-2648: WASM fix for s390x - #130
Conversation
Fixes https://issues.redhat.com/browse/MAISTRA-2648 The permanent fix is not a part of maistra/envoy yet: proxy-wasm/proxy-wasm-cpp-host#198
|
Hi @knm3000. Thanks for your PR. I'm waiting for a maistra member to verify that this patch is reasonable to test. If it is, they should reply with Once the patch is verified, the new status will be reflected by the I understand the commands that are listed here. DetailsInstructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
|
/ok-to-test |
oschaaf
left a comment
oschaaf
left a comment
There was a problem hiding this comment.
Just a thought about the way the required changes get patched in, the patch itself LGTM
|
|
||
| # wasm fix for s390x https://issues.redhat.com/browse/MAISTRA-2648 | ||
| # the permanent fix is https://github.com/proxy-wasm/proxy-wasm-cpp-host/pull/198 (not a part of maistra/envoy yet) | ||
| patch -p1 -i maistra/ci/proxy-wasm-cpp-host.patch No newline at end of file |
There was a problem hiding this comment.
Bazel provides a way to patch in changes to dependencies as well; which might be a little cleaner?
We could set up _proxy_wasm_cpp_host to apply the patch over at
https://github.com/maistra/envoy/blob/0f592ba9b37a354a97da929722f0c70d7d85106e/bazel/repositories.bzl#L793
WDYT?
There was a problem hiding this comment.
(following up on this would imply moving this PR over to maistra/envoy)
There was a problem hiding this comment.
Thanks for the review, I'll try to move the patch to maistra/envoy (and then update https://github.com/maistra/proxy/blob/maistra-2.1/WORKSPACE with the new envoy commit).
There was a problem hiding this comment.
It's not necessary to touch proxy after this. After your PR is merged on envoy side, automation takes place and will open a PR in proxy with the changes that got merged in envoy.
|
Opened maistra/envoy PR maistra/envoy#134 instead of this one. |
4 participants
Fixes https://issues.redhat.com/browse/MAISTRA-2648
The permanent fix is not a part of maistra/envoy yet:
proxy-wasm/proxy-wasm-cpp-host#198