Add support for gitee.com - #326
Conversation
tarsius
left a comment
tarsius
left a comment
There was a problem hiding this comment.
Please update the "Partially Supported Forges" node in the manual. (Only edit forge.org; I will regenerate forge.texi.)
| @@ -0,0 +1,38 @@ | |||
| ;;; forge-bitbucket.el --- Bitbucket support -*- lexical-binding: t -*- | |||
There was a problem hiding this comment.
You forgot to adjust this. When you edit this make sure -*- lexical-binding: t -*- begins at the same column as before.
| "git.sr.ht" forge-srht-repository) | ||
| ;; gitee (API unsupported) | ||
| ("gitee.com" nil | ||
| "gitee.com" forge-gitee-repository)) |
There was a problem hiding this comment.
Put this below the bitbucket entry into the "Forges (API unsupported)" group. (Don't add an additional comment, the comment I just mentioned covers that.)
|
Thank you for your guidance, I have changed according to what you said。 |
|
You omitted many of the slots that are set for many of the other classes. Why? |
|
i use M-x "forge-" to found the relation with them, but i can't found how to use them ,so i omit it. |
Some or even all of those are indeed unused. At present. I have added these slots because I expect to be using them eventually. Once that happens the values will already be ready to use for all forges that are currently supported. It would be nice if that also applied to gitee.com, especially because I don't use that myself, which means it would be more work for me to do it then than it would be for you to do it now. |
|
I notice you added the suggested commit summary when squashing the commits. Unfortunately you also added the period at the end of the summary back again. Please remove that like for all other commits in this repository. |
|
Please let me know when you have added the missing slots, then we can still add this. |
|
I have added a faq entry about the forges I plan or don't plan to support. Because I do not plan to implement support for this particular forge I am closing this issue. That doesn't mean that you cannot comment here or shouldn't discourage you from contributing support for favorite forge yourself. |
2 participants
Your software is very good, I like it very much, but in my country we work with gitee.com, I made a little change to open the commit and issues in gitee.com in emacs, I hope you can pass this pr, so that more people can use this little feature easily.