Skip to content

Fix forge-delete-post - #196

Closed
snogge wants to merge 2 commits into
magit:masterfrom
snogge:fix-delete-post
Closed

Fix forge-delete-post#196
snogge wants to merge 2 commits into
magit:masterfrom
snogge:fix-delete-post

Conversation

@snogge

@snogge snogge commented Sep 16, 2019

Copy link
Copy Markdown
Contributor

forge-delete-post' used to be forge-delete-comment', and it was
broken.

  • Rename forge-delete-comment' -> forge-delete-post'
  • Rename forge--delete-comment' -> forge--delete-post'
  • Move common code from forge--delete-post' to forge-delete-post'
  • Remove `forge-comment-at-point', no longer used

Closes #195.

`forge-delete-post' used to be `forge-delete-comment', and it was
broken.

* Rename `forge-delete-comment' -> `forge-delete-post'
* Rename `forge--delete-comment' -> `forge--delete-post'
* Move common code from `forge--delete-post' to `forge-delete-post'
* Remove `forge-comment-at-point', no longer used

Closes magit#195.
@tarsius

tarsius commented Sep 28, 2019

Copy link
Copy Markdown
Member

Move common code from forge--delete-post to forge-delete-post

That's not correct. forge--delete-post could be called elsewhere and has to cover the complete task of deleting the post. The magit-refresh should probably be moved, but I'll leave it where it is for the time being (because other low-level functions currently also refresh and I want to fix that in one go).

@tarsius tarsius closed this in 1d55229 Sep 28, 2019
@snogge
snogge deleted the fix-delete-post branch September 30, 2019 22:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Delete post does not work - and is called "delete comment"

2 participants