Address Benjie's review feedback on deploy preview#72
Merged
Conversation
- Add explicit `ref: main` to checkout step to prevent PR authors from poisoning the wrangler config via a crafted branch - Include commit hash in wrangler deploy message for traceability - Extract hide-old-comments logic into .github/scripts/ for readability - Add security comments documenting zip-slip safety (handled by actions/download-artifact) and static-only wrangler configuration Co-Authored-By: Claude <noreply@anthropic.com>
Contributor
🚀 Deploy Preview
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Applies the fixes suggested in graphql/gaps PR #40 code review by Benjie:
ref: mainon checkout - Prevents a malicious PR author from crafting a branch that poisons thewrangler.jsoncconfig used by the privileged deploy workflow${{ github.event.workflow_run.head_sha }}to the Wrangler versions upload message for traceability.github/scripts/- Moves the "hide old comments" GraphQL mutation logic intohide-old-deploy-comments.mjsfor readability and testabilityactions/download-artifact) and why the wrangler deploy is safe (static assets only)Test plan
Context
Testing these fixes in the staging repo before applying to graphql/gaps PR #40.
🤖 Generated with Claude Code