Merged
Conversation
dnzxy
approved these changes
Oct 5, 2025
marionbarker
approved these changes
Oct 6, 2025
Collaborator
marionbarker
left a comment
marionbarker
left a comment
There was a problem hiding this comment.
I reviewed the code and testing this in combinations with PR 445, 468 (this one) and 469.
Without this PR, when a bolus is recommended at Trio, the displayed recommended bolus in LoopFollow does not match the Trio recommended bolus.
With this PR, the displayed recommended bolus in LoopFollow is always blank.
LGTM
Contributor
Author
|
There is now a Trio PR that makes Trio upload the actual recommended bolus to the devicestatus in Nightscout. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Removed usage of
insulinReqfrom Nightscoutdevicestatus, as it is not suitable for displaying as a recommended bolus.This value is an internal oref field that is heavily adjusted and not equivalent to Trio’s bolus calculator output.
A proper replacement will be added later when the correct bolus recommendation becomes available from Trio.