Conversation
bjorkert
approved these changes
Sep 14, 2025
Contributor
bjorkert
left a comment
There was a problem hiding this comment.
Approved based on code review.
codebymini
added a commit
to CodeByMiniOrg/LoopFollow
that referenced
this pull request
Sep 30, 2025
marionbarker
approved these changes
Oct 1, 2025
Collaborator
marionbarker
left a comment
There was a problem hiding this comment.
The developer who created this PR has been using it in-vivo and remotely controlling Loop.
Tested by setting up LoopFollow to follow a Loop URL. All the remote control commands continue to work as expected. Sent from iOS 18.7 phone and an iOS 16.7.11 phone to the same URL using this code for carb, bolus, override start and override cancel.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR improves error handling and user guidance for Loop APNS remote functionality.
Changes
Error Handling:
User Guidance:
*Added environment-specific guidance messages for APNS configuration
Logging: