Reset Settings Navigation on Tab Switch#429
Merged
marionbarker merged 1 commit intodevfrom Jul 8, 2025
Merged
Conversation
marionbarker
approved these changes
Jul 8, 2025
Collaborator
marionbarker
left a comment
There was a problem hiding this comment.
Approving from test.
Code review
The code review looks reasonable.
Test
After building with this branch, tapping the settings icon on the toolbar takes the user to the top level settings screen.
This is the desired behavior.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Reset Settings Navigation on Tab Switch
Problem: When switching between tabs and returning to Settings, the navigation stack remained at the last viewed screen instead of returning to the root settings menu.
Solution:
settingsPathto the sharedObservableclass to manage settings navigation stateSettingsMenuViewto use the centralized navigation pathSettingsViewController.viewWillAppear()to ensure users always return to the root settings screenBenefits: