Improve initial setup and UI reactivity#426
Merged
marionbarker merged 1 commit intodevfrom Jul 7, 2025
Merged
Conversation
marionbarker
approved these changes
Jul 7, 2025
Collaborator
marionbarker
left a comment
There was a problem hiding this comment.
Code review
Not really able to do a code review - the changes seem appropriate, but not an expert.
Test
I switched between various NS URL for the test. I have:
- Loop with no treatments
- Loop from "real" users and test phones
- Trio from "real" users and test phones
I confirm that the remote configuration is restored to none when switching between URL, so the Alarm icon shows up in the tool bar.
I did not notice a difference when switching between URL for dev or this branch.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fix: Improve initial setup and UI reactivity
This pull request resolves a couple of issues to create a smoother experience for first-time users. It introduces dynamic UI updates and sets more sensible defaults.
Changes
SettingsMenuViewreactive to changes in the stored URL using@ObservedObject.remoteTypefor new users has been changed from.nightscoutto.none. This ensures that alarm settings are available as a tab by default until a user explicitly configures remote commands.