Clear override text conditionally based on device#423
Merged
Conversation
marionbarker
approved these changes
Jul 5, 2025
Collaborator
marionbarker
left a comment
There was a problem hiding this comment.
Code review
The code review looks appropriate
Test
I built this branch (as well as dev branch) on a test phone viewing both a Loop URL and Trio URL (at separate times). I did not notice a difference with the Loop URL between the dev and trio-override builds.
Trio URL
- With
dev:- disabling an override removed the override from the display completely (instead of changing the end point)
- With
trio-override:- disabling an override updated the end point to the actual duration
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This pull request resolves issue #403.
Description:
This change introduces a conditional clearing of the override information in the
infoManager. Previously, the override data was cleared every time the device status was updated.This caused an issue for Trio users, where the override text would disappear from the display. This happened because for Trio, override information is fetched from treatments, and the device status does not contain this data. If a device status update occurred after the treatment data was processed, the override information would be incorrectly cleared.
For "Loop" devices, the override information is part of the device status, so clearing it upon refresh is the correct behavior to ensure the display is up-to-date.
Changes:
updateDeviceStatusDisplay(jsonDeviceStatus:), the call toinfoManager.clearInfoData(types: [.override])is now wrapped in a conditional check.This ensures that the override information is handled correctly for both Loop and Trio users, fixing the glitch where the override text would intermittently disappear for the latter.