Conversation
marionbarker
approved these changes
Jul 5, 2025
Collaborator
marionbarker
left a comment
There was a problem hiding this comment.
Code review
Code review looks appropriate
Test
I have not tested this by reproducing the error and demonstrating that it is fixed.
I have built it and heard speakBG work as expected while app is in the foreground.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
This PR addresses three key issues with the "Speak BG" feature:
Restoring Bluetooth Background Mode
The "Speak BG" feature was failing for users on the Bluetooth background refresh setting because iOS was denying the app's request to activate an audio session from a background state.
This has been fixed by implementing a more robust
AVAudioSessionmanagement strategy:Improved Announcement Logic & Bug Fix
The previous logic used a simple 30-second timer to prevent repeated announcements. This was inefficient and led to bugs where old BG values could be repeated after certain actions, like remote commands.
The announcement logic has been completely rewritten:
This new data-driven approach is more reliable and naturally prevents the repetition of old data.
Resolves: #343