Conversation
marionbarker
left a comment
There was a problem hiding this comment.
Limited addition
This only covers part the request (from Issue #333) but I understand that expanded capability will need to wait.
This code change enables users who do not use remote control to have the alarm button show up on the task bar. It limits users to either remote control (if enabled) or alarm button (only if remote control is disabled) to show up in the second spot of the task bar.
Code Review
Code changes appear appropriate for the limited change provided.
Test
The alarm button shows up in the second spot of the task bar when remote control is set to none.
marionbarker
left a comment
There was a problem hiding this comment.
Oops - there is a linting change that was not committed. Might want to fix that before merging.
LoopFollow/ViewControllers/AlarmViewController.swift
|
Thanks, i re-built and pushed the result of the Lint. |
marionbarker
left a comment
There was a problem hiding this comment.
I confirmed the linting fix. Approving again.
Description
This PR introduces a dynamic second tab in the tab bar. 🛠️
For users who have remote functionality enabled (i.e.,
remoteTypeis not.none), the second tab will continue to show the Remote view.For users who do not use the remote features (
remoteTypeis.none), this change restores the Alarms view to the second tab. This provides these users with quick and convenient access to alarm configuration without having to navigate through the settings menu.This implementation listens for changes to the
remoteTypesetting and updates the tab bar in real-time.