Implement Secure Inputs for Dexcom and Nightscout Credentials#419
Merged
Implement Secure Inputs for Dexcom and Nightscout Credentials#419
Conversation
marionbarker
approved these changes
Jul 5, 2025
Collaborator
marionbarker
left a comment
There was a problem hiding this comment.
Code Review
Looks reasonable.
Test
Built this branch and the token (for NS) and the password (for Dexcom Share) are both hidden by default and can be revealed with a tap on the eyeball.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
PR: Implement Secure Inputs for Dexcom and Nightscout Credentials
Closes #417
Description
This pull request addresses the issue of sensitive credentials (Dexcom password and Nightscout token) being displayed in plain text in the settings views. To enhance security and user privacy, the standard
TextFieldhas been replaced with the existingTogglableSecureInputcomponent for these fields.Changes Made
DexcomSettingsView.swift:TextFieldfor the password withTogglableSecureInput.HStacks for consistent UI alignment.NightscoutSettingsView.swift:TextFieldfor the "Access Token" withTogglableSecureInput.HStackfor better alignment of the label and the input field.Impact
TogglableSecureInput) for a consistent approach to handling secrets across the app.This resolves the concerns raised in issue #417 by ensuring all sensitive credential fields are properly secured.