Conversation
dnzxy
approved these changes
Jun 17, 2025
Collaborator
dnzxy
left a comment
There was a problem hiding this comment.
Absolutely sane and surgical check update. LGTM.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What & Why
dexShare?.fetchData()could return an empty array even when the network call succeeds.Our previous guard only checked for
nil, so subscriptingdata[0]would crash with “index out of range”.Changes
guard let data = result, !data.isEmptyHow to test
[].webLoadNSBGData()is executed.Notes
No functional changes beyond the safety check.