Update BLT to apply MPI flags for the respective compilers to only the respective compiler lines#771
Update BLT to apply MPI flags for the respective compilers to only the respective compiler lines#771aaroncblack wants to merge 1 commit into
Conversation
|
I made heavy use of codex on this, so take it with a grain of salt. |
| set(_mpi_includes ) | ||
| set(_mpi_libraries ) | ||
| set(_mpi_link_flags ) | ||
| set(_mpi_fortran_includes ) |
There was a problem hiding this comment.
@white238 I told the agent that our C++ codes make heavy use of the C MPI API, so to focus on splitting out the C/C++ vs the Fortran paths and flags.
It said in many MPI installs the MPI_C_INCLUDE_DIRS and MPI_CXX_INCLUDE_DIRS are identical, but if its a concern, another option is to have the C++ get both C and CXX mpi flags and paths, de-duplicated.
|
there are actually several issues related to this we have discussed solutions, I dont think we have really captured those discussions well. What I recall: |
I encountered issues building a C++/Fortran code using a mixed vendor compiler clang/gfortran set up. The BLT mpi target added the C++ mpi paths to the general compiler flags, resulting in the gfortran compiles failing.
Description of changes:
Update BLT to apply MPI flags for the respective compilers to only the respective compiler lines.
Add test that builds a mixed language executable and confirms the respective MPI flags and include paths for C, C++, and Fortran are only added to language compile lines.