This repository was archived by the owner on Aug 24, 2023. It is now read-only.
Enable controlling local stream mirroring by introducing isMirrored-prop#82
Merged
Merged
Conversation
* the `isLocal &&` logic was effectively duplicated in `isFrontFacing`, but does not semantically answer this yes/no question * `isFrontFacing` was not the most appropriate name so far, as it is also `true` when `facingMode` or `mediaStreamTrack` are undefined, hence this is a better name
🦋 Changeset detectedLatest commit: 3156bef The changes in this PR will be included in the next version bump. This PR includes changesets to release 1 package
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
davidzhao
approved these changes
Aug 6, 2022
davidzhao
left a comment
davidzhao
left a comment
Member
There was a problem hiding this comment.
looks good! thank you for fixing this.
Merged
Contributor
Author
|
@davidzhao my pleasure 😇 Maybe somebody could add a checkbox to control this prop to the example app? |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This is my suggestion to give people a way to avoid the problem described in #29
If somebody would like to add a checkbox to control this prop into the live example app, that'd be great (i don't have an access token at hand to test this).