feat(builder): consolidate expression construction#639
Merged
Conversation
Codecov Report❌ Patch coverage is Additional details and impacted files@@ Coverage Diff @@
## main #639 +/- ##
==========================================
+ Coverage 76.82% 76.95% +0.13%
==========================================
Files 473 473
Lines 66108 66076 -32
Branches 9821 9799 -22
==========================================
+ Hits 50785 50850 +65
+ Misses 12031 11956 -75
+ Partials 3292 3270 -22
Flags with carried forward coverage won't be shown. Click here to find out more.
🚀 New features to boost your workflow:
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
count_over()support and reconcile SQLGlot required expression argumentsWhy
Builder expression construction had accumulated parallel normalization, coercion, and parsing paths. Consolidating them reduces drift while preserving rendered SQL and parameter binding.
Impact
count_over()now acceptsorder_byconsistently with other window helpers. Scalar and aggregate helpers accept the same builder-native expression shapes. WHERE, subquery, and JOIN inputs now consistently retain placeholders and values across both supported SQL-object protocols. Materialized views render canonical PostgreSQLWITH DATAandWITH NO DATAclauses.Validation
uv run pytest tests/unit/builder/ -q(911 passed)make lintmake type-checkThe repository compiled-install target was attempted twice but stalled without diagnostics during the package build; each attempt was interrupted and its temporary build configuration was restored.