Skip to content

Fit to width and height#155

Merged
clefebvre merged 2 commits into
linuxmint:masterfrom
programmer-ceds:FitWidthAndHeight
Nov 29, 2021
Merged

Fit to width and height#155
clefebvre merged 2 commits into
linuxmint:masterfrom
programmer-ceds:FitWidthAndHeight

Conversation

@programmer-ceds

Copy link
Copy Markdown
Contributor

Add menu and short-cut commands to fit to height or width. For further details see PR #143 - which was closed due to difficulties resubmitting a PR that was started with HTTPS now that SSH is mandatory.

@clefebvre - see what you think regarding centring the scrolling if the menu keys are used - this submitted version uses the mouse position even when the menu is used.

@clefebvre

Copy link
Copy Markdown
Member

The symbolic icons aren't symbolic. They appear as mono (gray) instead of changing based on the background color.

I think it might be because you're shipping png versions here.

@clefebvre

Copy link
Copy Markdown
Member

ok confirmed, if I remove the pngs, the symbolics work well.

@clefebvre

Copy link
Copy Markdown
Member
  • You mixed up some code in this PR. For instance you're going back to BILINEAR..
  • That webp change looks like it belongs in a different PR
  • The PNG files need to be removed

@clefebvre

Copy link
Copy Markdown
Member

I'll mark this as Next for inclusion in Mint 21.

I'm worried it might delay 20.3, especially since it requires new translations.

@clefebvre clefebvre changed the title Fit to width and height [Next] Fit to width and height Nov 28, 2021
@programmer-ceds

Copy link
Copy Markdown
Contributor Author

@clefebvre - sorry about that - I forgot the step of comparing and merging my edited files with the latest versions downloaded (which as I created a new fork of course included all of the other changes that I was then unintentionally reverting!)

I have removed the png icons and uploaded the original copies of the Makefile.am files for the icon sizes for which I deleted the png files.

Hopefully all should now be right.

@clefebvre

Copy link
Copy Markdown
Member

Quick review looks good, thanks @programmer-ceds.

@clefebvre clefebvre changed the title [Next] Fit to width and height Fit to width and height Nov 29, 2021
@clefebvre clefebvre merged commit d2d7584 into linuxmint:master Nov 29, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants