Skip to content

fix: complete Traditional Chinese shortcut translations - #125

Closed
yixinshark wants to merge 1 commit into
linuxdeepin:masterfrom
yixinshark:fix/complete-traditional-chinese-shortcut-translations
Closed

fix: complete Traditional Chinese shortcut translations#125
yixinshark wants to merge 1 commit into
linuxdeepin:masterfrom
yixinshark:fix/complete-traditional-chinese-shortcut-translations

Conversation

@yixinshark

@yixinshark yixinshark commented Aug 4, 2026

Copy link
Copy Markdown
Contributor

Summary

  • synchronize zh_HK and zh_TW keybinding catalogs with all 55 Simplified Chinese source entries
  • synchronize application shortcut catalogs with all 44 Simplified Chinese source entries
  • provide region-specific Traditional Chinese terminology and remove unfinished translations

Test plan

  • validate all four TS files with xmllint
  • verify source entry count and order match the corresponding zh_CN catalogs
  • compile all four catalogs with Qt 6 lrelease

Summary by Sourcery

Complete and synchronize Traditional Chinese shortcut and keybinding translation catalogs for Hong Kong and Taiwan locales with the Simplified Chinese source entries.

Bug Fixes:

  • Replace unfinished or missing Traditional Chinese shortcut translations with complete, region-appropriate terminology for zh_HK and zh_TW.

Enhancements:

  • Add full Traditional Chinese translations for all keybinding actions in zh_HK and zh_TW catalogs, including touchpad gestures, window and workspace controls, and system features.
  • Add full Traditional Chinese translations for all application shortcut actions in zh_HK and zh_TW catalogs, covering system utilities, screenshot modes, accessibility tools, and window management options.
  • Set explicit TS language attributes for the Hong Kong and Taiwan shortcut translation files to match their respective locales.

Synchronize the Hong Kong and Taiwan translation catalogs with the current Simplified Chinese shortcut entries.
- Add localized translations for all keybinding and application shortcut messages.
- Remove obsolete source entries and clear unfinished translation markers.
- Preserve regional terminology differences between zh_HK and zh_TW.

将香港繁体和台湾繁体翻译目录与当前简体中文快捷键条目同步。
- 补齐按键绑定和应用快捷键的全部本地化翻译。
- 移除过期源文案并清除未完成翻译标记。
- 保留 zh_HK 与 zh_TW 的地区用语差异。

Log: complete Traditional Chinese shortcut translations
Change-Id: I486ddcbab703a3f491d715e7da292d221f0b39d1
@deepin-ci-robot

Copy link
Copy Markdown

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: yixinshark

The full list of commands accepted by this bot can be found here.

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@sourcery-ai

sourcery-ai Bot commented Aug 4, 2026

Copy link
Copy Markdown

Reviewer's Guide

This PR completes and synchronizes Traditional Chinese (zh_HK, zh_TW) shortcut translation catalogs with the Simplified Chinese sources, adding all missing messages, setting TS language metadata, and providing region-specific wording for keybindings and application shortcuts.

File-Level Changes

Change Details Files
Complete and synchronize Traditional Chinese keybinding shortcut catalogs with Simplified Chinese source entries.
  • Set TS language attributes for Traditional Chinese keybinding catalogs
  • Replace unfinished translations with completed Traditional Chinese strings for existing messages
  • Add all missing gesture, multitasking, workspace, window, system, and assistive tool shortcut messages to match the zh_CN catalog, with region-appropriate wording for zh_HK and zh_TW
src/plugin-qt/shortcut/translations/org.deepin.dde.keybinding_zh_HK.ts
src/plugin-qt/shortcut/translations/org.deepin.dde.keybinding_zh_TW.ts
Complete and align Traditional Chinese application shortcut catalogs with Simplified Chinese source entries.
  • Set TS language attributes for Traditional Chinese app shortcut catalogs
  • Fill in previously unfinished translations for app-level shortcuts (clipboard, lock screen, notification center, shutdown, launcher, window actions, screenshots, etc.)
  • Add missing screenshot, system, workspace, window management, assistive tools, zoom and effect-switching shortcut messages to match the zh_CN catalog, with regional terminology for zh_HK and zh_TW
src/plugin-qt/shortcut/dde-app-shortcuts/translations/org.deepin.dde.shortcut.dde-app_zh_HK.ts
src/plugin-qt/shortcut/dde-app-shortcuts/translations/org.deepin.dde.shortcut.dde-app_zh_TW.ts

Tips and commands

Interacting with Sourcery

  • Trigger a new review: Comment @sourcery-ai review on the pull request.
  • Continue discussions: Reply directly to Sourcery's review comments.
  • Generate a GitHub issue from a review comment: Ask Sourcery to create an
    issue from a review comment by replying to it. You can also reply to a
    review comment with @sourcery-ai issue to create an issue from it.
  • Generate a pull request title: Write @sourcery-ai anywhere in the pull
    request title to generate a title at any time. You can also comment
    @sourcery-ai title on the pull request to (re-)generate the title at any time.
  • Generate a pull request summary: Write @sourcery-ai summary anywhere in
    the pull request body to generate a PR summary at any time exactly where you
    want it. You can also comment @sourcery-ai summary on the pull request to
    (re-)generate the summary at any time.
  • Generate reviewer's guide: Comment @sourcery-ai guide on the pull
    request to (re-)generate the reviewer's guide at any time.
  • Resolve all Sourcery comments: Comment @sourcery-ai resolve on the
    pull request to resolve all Sourcery comments. Useful if you've already
    addressed all the comments and don't want to see them anymore.
  • Dismiss all Sourcery reviews: Comment @sourcery-ai dismiss on the pull
    request to dismiss all existing Sourcery reviews. Especially useful if you
    want to start fresh with a new review - don't forget to comment
    @sourcery-ai review to trigger a new review!

Customizing Your Experience

Access your dashboard to:

  • Enable or disable review features such as the Sourcery-generated pull request
    summary, the reviewer's guide, and others.
  • Change the review language.
  • Add, remove or edit custom review instructions.
  • Adjust other review settings.

Getting Help

@sourcery-ai sourcery-ai Bot left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hey - I've reviewed your changes and they look great!


Sourcery is free for open source - if you like our reviews please consider sharing them ✨
Help me be more useful! Please click 👍 or 👎 on each comment and I'll use the feedback to improve your reviews.

@deepin-ci-robot

Copy link
Copy Markdown

deepin pr auto review

★ 总体评分:100分

■ 【总体评价】

代码补全了四个繁体中文翻译文件并新增大量快捷键翻译,格式规范且用词准确。
逻辑正确且无任何安全风险,得满分。

■ 【详细分析】

  • 1.语法逻辑(完全正确)✓

XML 结构完整闭合,补全了 TS 根节点缺失的 language 属性(language="zh_HK" 和 language="zh_TW"),并正确移除了所有 translation 节点中的 type="unfinished" 标记,符合 Qt Linguist 翻译文件规范。

  • 2.代码质量(优秀)✓

翻译内容高度契合各地用语习惯,如 zh_HK 使用“屏幕”、“短按”、“延時”,zh_TW 使用“螢幕”、“輕觸”、“延遲”;全文件缩进格式从原先的不规则调整为统一的两个空格缩进,提升了可读性。

  • 3.代码性能(无性能问题)✓

纯静态 XML 翻译资源文件,仅在编译期或运行期按需加载字符串,不涉及算法复杂度或系统调用。

  • 4.代码安全(存在0个安全漏洞)✓

漏洞对比统计:新增漏洞 0 个,减少漏洞 0 个,持平 0 个
纯文本翻译文件,不包含可执行逻辑、动态变量解析或外部资源引用,无任何攻击面。

■ 【改进建议代码示例】

<?xml version="1.0" encoding="utf-8"?>
<!DOCTYPE TS>
<TS version="2.1" language="zh_TW">
  <context>
    <name>org.deepin.dde.keybinding</name>
    <message>
      <source>Swipe down with three fingers</source>
      <translation>三指向下滑動</translation>
    </message>
    <message>
      <source>Lock screen</source>
      <translation>鎖定螢幕</translation>
    </message>
  </context>
</TS>

@BLumia

BLumia commented Aug 5, 2026

Copy link
Copy Markdown
Member

#119

@BLumia BLumia closed this Aug 5, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants