feat(ambient-brightness): add ambient light sensor based auto brightn… - #118
Open
fly602 wants to merge 1 commit into
Open
feat(ambient-brightness): add ambient light sensor based auto brightn…#118fly602 wants to merge 1 commit into
fly602 wants to merge 1 commit into
Conversation
![sourcery-ai[bot]](https://avatars.githubusercontent.com/in/48477?s=60&v=4){kind=small}
|
[APPROVALNOTIFIER] This PR is NOT APPROVED This pull-request has been approved by: fly602 The full list of commands accepted by this bot can be found here. DetailsNeeds approval from an approver in each of these files:Approvers can indicate their approval by writing |
Reviewer's GuideAdd a new ambient-brightness plugin that exposes org.deepin.dde.AmbientBrightness1 on D-Bus, implements continuous ambient light based brightness recommendation with hysteresis/debounce and lifecycle handling, wires it into the Qt plugin build, and refactors existing power and shortcut code to rely on the new DBus state instead of the old DConfig toggle, preventing conflicts with power save brightness adjustments. Sequence diagram for ambient brightness recommendation and power-plan guardsequenceDiagram
participant SensorProxy as net_hadess_SensorProxy
participant AmbientBrightnessService
participant AmbientBrightnessModel
participant ContinuousAmbientLightPolicy
participant AmbientBrightness1 as org_deepin_dde_AmbientBrightness1
participant SessionDBusProxy
participant PowerManager
participant PowerSavePlan
SensorProxy->>AmbientBrightnessService: PropertiesChanged(LightLevel)
AmbientBrightnessService->>AmbientBrightnessModel: submitSample(lux, timestamp)
AmbientBrightnessModel->>ContinuousAmbientLightPolicy: update(SensorSample)
ContinuousAmbientLightPolicy-->>AmbientBrightnessModel: Recommendation
AmbientBrightnessModel-->>AmbientBrightnessService: recommendedBrightnessChanged(brightness)
AmbientBrightnessService-->>AmbientBrightness1: PropertiesChanged(State=Active, RecommendedBrightness)
PowerSavePlan->>PowerManager: isAmbientBrightnessActive()
PowerManager->>SessionDBusProxy: isAmbientBrightnessActive()
SessionDBusProxy->>AmbientBrightness1: get Property(State)
AmbientBrightness1-->>SessionDBusProxy: State
SessionDBusProxy-->>PowerManager: bool
alt ambient brightness active
PowerSavePlan-->>PowerSavePlan: [skip brightness change]
else inactive
PowerSavePlan-->>PowerSavePlan: applyBrightnessDrop()/resetBrightness()
end
File-Level Changes
Tips and commandsInteracting with Sourcery
Customizing Your ExperienceAccess your dashboard to:
Getting Help
|
fly602
force-pushed
the
master
branch
4 times, most recently
from
July 31, 2026 06:59
8ae717f to
e346e81
Compare
|
TAG Bot New tag: 1.0.37 |
fly602
force-pushed
the
master
branch
2 times, most recently
from
August 4, 2026 07:49
e61173a to
29e7d37
Compare
1. Add an ambient brightness service backed by iio-sensor-proxy 2. Convert lux samples into stable brightness recommendations with filtering, hysteresis, and debounce 3. Coordinate sensor lifecycle with lid, sleep, session, service, and configuration state Influence: 1. Publish automatic brightness state and recommendations through org.deepin.dde.AmbientBrightness1 2. Prevent power-saving and manual brightness paths from conflicting with ambient brightness 3. Verify sensor lifecycle and brightness policy with unit tests fix: 支持环境光自动亮度调节 1. 新增基于iio-sensor-proxy的环境光亮度服务 2. 通过滤波、滞回和防抖将lux样本转换为稳定的亮度推荐值 3. 根据合盖、休眠、会话、传感器服务及配置状态管理光感生命周期 Influence: 1. 通过org.deepin.dde.AmbientBrightness1发布自动亮度状态及推荐值 2. 避免省电及手动亮度调节路径与环境光自动亮度冲突 3. 通过单元测试验证光感生命周期及亮度策略 PMS: BUG-372191
deepin pr auto review★ 总体评分：95分■ 【总体评价】
■ 【详细分析】
■ 【改进建议代码示例】 // ambientbrightnessservice.cpp
// 将同步的 ClaimLight 调用改为异步调用，防止主线程被 system bus 阻塞
void AmbientBrightnessService::connectSensor()
{
disconnectSensor();
auto systemBus = QDBusConnection::systemBus();
m_sensor = new QDBusInterface(QString::fromLatin1(kSensorService),
QString::fromLatin1(kSensorPath),
QString::fromLatin1(kSensorInterface),
systemBus, this);
if (!m_sensor->isValid()) {
qCWarning(logAmbientBrightness) << "sensor interface invalid";
delete m_sensor;
m_sensor = nullptr;
m_model.makeUnavailable();
return;
}
const bool hasAmbientLight = m_sensor->property("HasAmbientLight").toBool();
const QString unit = m_sensor->property("LightLevelUnit").toString();
if (!hasAmbientLight || (!unit.isEmpty() && unit != QLatin1String("lux"))) {
delete m_sensor;
m_sensor = nullptr;
m_model.makeUnavailable();
return;
}
const bool signalConnected = systemBus.connect(
QString::fromLatin1(kSensorService), QString::fromLatin1(kSensorPath),
QString::fromLatin1(kPropertiesInterface), QStringLiteral("PropertiesChanged"),
this, SLOT(onPropertiesChanged(QString,QVariantMap,QStringList)));
if (!signalConnected) {
qCWarning(logAmbientBrightness) << "failed to subscribe to sensor PropertiesChanged"
<< systemBus.lastError().message();
delete m_sensor;
m_sensor = nullptr;
m_model.makeUnavailable();
return;
}
m_waitingForInitialSample = true;
m_claimInProgress = true;
m_havePendingInitialSample = false;
// 使用异步调用替代同步的 m_sensor->call(QStringLiteral("ClaimLight"))
auto *reply = m_sensor->asyncCall(QStringLiteral("ClaimLight"));
QDBusPendingCallWatcher *watcher = new QDBusPendingCallWatcher(reply, this);
connect(watcher, &QDBusPendingCallWatcher::finished, this,
[this, watcher](QDBusPendingCallWatcher *self) {
self->deleteLater();
m_claimInProgress = false;
QDBusReply<void> claimReply = *self;
if (!claimReply.isValid()) {
qCWarning(logAmbientBrightness) << "ClaimLight failed" << claimReply.error().message();
stopInitialSampleWait();
QDBusConnection::systemBus().disconnect(
QString::fromLatin1(kSensorService), QString::fromLatin1(kSensorPath),
QString::fromLatin1(kPropertiesInterface),
QStringLiteral("PropertiesChanged"), this,
SLOT(onPropertiesChanged(QString,QVariantMap,QStringList)));
delete m_sensor;
m_sensor = nullptr;
m_model.makeUnavailable();
return;
}
m_claimed = true;
m_haveSample = false;
m_model.waitForSample();
qCDebug(logAmbientBrightness) << "sensor claimed async successfully";
if (m_havePendingInitialSample) {
const double pendingLux = m_pendingInitialLux;
stopInitialSampleWait();
processLux(pendingLux);
} else {
startInitialSampleTimeout();
}
});
} |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
…ess plugin
Add a new ambient-brightness plugin that reads lux from iio-sensor-proxy, applies filtering, hysteresis, and debouncing, and publishes recommended brightness via DBus (org.deepin.dde.AmbientBrightness1). Refactor the power plugin to remove the old DConfig-based ambient brightness toggle, add isAmbientBrightnessActive() guard to PowerSavePlan so brightness save-plan operations don't conflict with ambient auto brightness. Remove redundant auto-brightness disable logic from dde-shortcut-tool since Display1.ChangeBrightness already calls prepareManualBrightnessChange() which disables ambient brightness via DBus.
新增环境光自动亮度插件，从 iio-sensor-proxy 读取 lux 值，经过滤波、滞回
和防抖处理后通过 DBus 发布推荐亮度。重构 power 插件，删除旧的 DConfig
自动亮度开关，在 PowerSavePlan 中添加 isAmbientBrightnessActive 守卫避免 省电计划与自动亮度冲突。移除 dde-shortcut-tool 中冗余的自动亮度关闭逻辑
（Display1.ChangeBrightness 已通过 prepareManualBrightnessChange 处理）。
Log: add ambient brightness plugin and refactor power/shortcut for auto brightness
Summary by Sourcery
Introduce a new ambient brightness plugin that exposes automatic brightness recommendations over DBus and integrates it with existing power and shortcut components.
New Features:
Enhancements:
Build:
Documentation:
Tests: