Non-Intel linux configs: make sure AES is enabled (CONFIG_CRYPTO_AES_NI_INTEL won't work there)#1434
Merged
tlaurion merged 1 commit intolinuxboot:masterfrom Jul 6, 2023
Conversation
Collaborator
|
Whoops, looks fine for merge to me 👍 |
…NI_INTEL won't work there) kgpe-d16 linux configs: disable CONFIG_CRYPTO_AES_NI_INTEL (not avail on AMD) This applied to Q35 qemu board which is AMD, not intel. generic AES needs to be enabled on non-intel boards, otherwise cryptsetup doesn't know how to deal with xts-plain Then saved back with linux.save_in_oldconfig_format_in_place
tlaurion
force-pushed
the
non-intel_readd-AES-for-cryptsetup
branch
from
f50cccc to
4f367d9
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
kgpe-d16 linux configs: disable CONFIG_CRYPTO_AES_NI_INTEL (not avail on AMD), enable generic AES.
qemu linux config: adding generic AES support, not removing CONFIG_CRYPTO_AES_NI_INTEL (in case someone wants to explore with intel coreboot qemu support later on)
This applied to Q35 qemu board which is AMD, not intel. generic AES needs to be enabled on non-intel boards, otherwise cryptsetup doesn't know how to deal with xts-plain
Test point:
cryptsetup benchmarkOtherwise cryptsetup fails call fails.