Fixes a bug the bootstrap of Charpoly ArithProgPrecond method#382
Open
ClementPernet wants to merge 4 commits into
Open
Fixes a bug the bootstrap of Charpoly ArithProgPrecond method#382ClementPernet wants to merge 4 commits into
ClementPernet wants to merge 4 commits into
Conversation
…ix, not just the first N rows. Fixes #381. Add a regression test
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This is a fix to #381 .
As noted by @gilvillard the call to
LUdivineon the Krylov matrix in the bootstrap phase of ArtihProgPrecond method was wrong, as it did not eliminate rows after the N-th row.After inspection of the code, I realised another bug, which was harmless, but could have lead to minor inefficiencies: one of the completed Krylov blocks identified in this bootstrap was not pushed, and as a consequence, it was left to the main arithprog algorithm to re-discover this factor. It has been also fixed now, and required to handle the N=0 case in ArithProg.