fix: add aria-label to #startStopBtn for screen reader accessibility#785
Merged
fix: add aria-label to #startStopBtn for screen reader accessibility#785
Conversation
Agent-Logs-Url: https://github.com/librespeed/speedtest/sessions/cfb05653-7d75-4f0d-9e9a-1765eeaa8903 Co-authored-by: sstidl <12804296+sstidl@users.noreply.github.com>
Copilot created this pull request from a session on behalf of
sstidl
April 13, 2026 05:51
View session
Contributor
Review Summary by QodoAdd aria-label to start/stop button for screen reader accessibility
WalkthroughsDescription• Add aria-label="Start" attribute to start/stop button HTML • Dynamically update aria-label when test starts/ends • Ensures screen readers announce button state correctly • Improves accessibility across all example pages Diagramflowchart LR
A["Button HTML"] -->|"Add aria-label=Start"| B["Initial State"]
C["startStop() function"] -->|"Set aria-label=Abort"| D["Test Running"]
E["s.onend callback"] -->|"Set aria-label=Start"| F["Test Ended"]
D -->|"User aborts"| F
File Changes1. index-classic.html
|
Contributor
Code Review by Qodo🐞 Bugs (0) 📘 Rule violations (0) 📎 Requirement gaps (0)
Great, no issues found!Qodo reviewed your code and found no material issues that require reviewⓘ The new review experience is currently in Beta. Learn more |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The Start/Abort button has no accessible name because its visible label comes solely from CSS
:beforecontent, which is not exposed to assistive technologies. Screen readers announce an unnamed button with no indication of its current action.Changes
aria-label="Start"to every<button id="startStopBtn">so the button has an accessible name on initial render.startStop()+s.onend(all pages): Dynamically updatearia-labelin sync with therunningclass toggle:Files updated:
index-classic.htmland all 7 pages underexamples/.