-
Notifications
You must be signed in to change notification settings - Fork 922
Make owner validation configurable #2093
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
+91
−0
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
28c7967 to
9014820
Compare
bording
approved these changes
Nov 26, 2024
Member
|
@ltrzesniewski Thanks for the PR. Of the open PRs for this feature, yours was was the most complete (it even included a test!) so I decided to it to get this feature in. I made a few tweaks, primarily moving away from a property and instead having separate get/set methods. Overall I think separate methods make more sense when there are separate libgit2 methods that need to be called. |
This was referenced Nov 26, 2024
This was referenced Dec 10, 2025
This was referenced Dec 24, 2025
This was referenced Dec 31, 2025
This was referenced Jan 7, 2026
This was referenced Jan 28, 2026
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This adds a
GlobalSettings.OwnerValidationproperty which wrapsgit_libgit2_opts(GIT_OPT_[GET/SET]_OWNER_VALIDATION).I needed to disable this (I'm using a safe environment), and I had to do this through reflection, but I suppose other people may have the same problem so exposing the feature in the library would be better. 🙂
Closes #2036
Edit: I'm an idiot, I forgot to check whether someone else submitted a PR for this, so this duplicates #2042, sorry 🤦
I'm leaving this open so you can choose the implementation, and this one also lets you retrieve the current option value.