Add detached lifecycle mode for persistent clusters#29
Open
m3ridian-zero wants to merge 1 commit into
Open
Conversation
Add an opt-in lifecycleMode option so callers can start Postgres isolated from parent process shutdown and terminal signals while preserving the managed default behavior. Refs: leinelissen#28 Constraint: Preserve current managed lifecycle by default Scope-risk: moderate Not-tested: Detached integration test blocked locally because binary download requires tar plus xz/zstd utilities Confidence: medium
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Refs #28.
Adds an opt-in lifecycle mode for callers that need a persistent embedded Postgres cluster to outlive the process that started it.
lifecycleMode: 'managed' | 'detached'managedas the default so existing process-exit cleanup behavior is preservedCreateProcessWwithCREATE_NO_WINDOW, tracking the postmaster PID for explicitstop()SELECT 1stop()supported for detached clustersVerification
npx -p node@20 node node_modules/lerna/cli.js run buildnpx -p node@20 npm run lintfrom the embedded-postgres packagenpx -p node@20 npm test -- tests/index.test.ts -t "detached cluster"npx -p node@20 npm test -- tests/index.test.ts -t "should be able to start and stop a cluster"Note: the full Windows package test file still has an unrelated pre-existing permission-bit assertion for
.exefiles; I left that behavior unchanged and verified the PR-specific detached path plus the managed default start/stop path.