Release PR for Sprint ending 2021-03-15#3023
Merged
Merged
Conversation
so they do not re-appear as pending invitations. Fixes #2990
Bumps [elliptic](https://github.com/indutny/elliptic) from 6.5.3 to 6.5.4. - [Release notes](https://github.com/indutny/elliptic/releases) - [Commits](indutny/elliptic@v6.5.3...v6.5.4) Signed-off-by: dependabot[bot] <support@github.com>
Make the component's reactivity work also when receiving updated value from its mother component. In a mostly async environment, we can't be sure that the first value received is the correct, up-to-date value, and not the previous outdated value. It can happen that the up-to-date value that should be rendered arrives a couple of milliseconds later, and without reactivity also working from outside to inside, the outdated value would be displayed in such cases. Fixes #2888
- Content defaults are saved in `diffTracker.contentDefaults`, not in `diffTracker.content_defaults` - Prioritize `diffTracker`'s values over `channel.content_defaults` as diffTracker contains the latest updates
…n/elliptic-6.5.4 Bump elliptic from 6.5.3 to 6.5.4
…ot-visible Content defaults reactivity fixes
add distinct to pagination querysets
Member
radinamatic
approved these changes
Mar 16, 2021
Member
radinamatic
left a comment
radinamatic
left a comment
There was a problem hiding this comment.
Manual QA passed (#2888 will likely need more work, but does not seem a blocker, I believe).
rtibbles
approved these changes
Mar 16, 2021
bjester
approved these changes
Mar 16, 2021
Merged
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
6 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Release PR for Sprint ending March 16
Fixes for:
#2989, #2990 and #1404
For Fix 1
Using the user@c.com created by the devsetup script, I invite a@a.com to be viewer of "empty channel".
After logging in as a@a.com, I decline the invitation.
After logging back in as user@c.com, I see that a@a.com's invite is gone (previously, it would show up upon logging in and going to the sharing page, but would disappear after a refresh)
For Fix 2
(Use two different browsers, e.g. firefox and chrome for each account)
As c, invite a to view a channel (do not leave the Sharing page)
As a, accept the invitation
As c, refresh the page to see that a has accepted the invitation (at this point, the invitation might still be in vuex in a stale unaccepted state).
As c, remove a's view access
a should disappear from the table
#2888 (part 1)
#2998
Testing with the Admin Table users tab