Fix "randomize question order" field not being synced when toggling its checkbox in EditModal#2956
Conversation
rtibbles
left a comment
There was a problem hiding this comment.
Code changes look good - a regression test would be great.
| mastery_model = ChoiceField( | ||
| choices=exercises.MASTERY_MODELS, allow_null=True, required=False | ||
| ) | ||
| randomize = BooleanField() |
There was a problem hiding this comment.
Could you either add this to this test here: https://github.com/learningequality/studio/blob/hotfixes/contentcuration/contentcuration/tests/viewsets/test_contentnode.py#L534 or create a similar test specifically for randomize?
There was a problem hiding this comment.
I added a section for randomize in th existing unit test
Codecov Report
@@ Coverage Diff @@
## hotfixes #2956 +/- ##
============================================
+ Coverage 80.80% 85.59% +4.78%
============================================
Files 281 299 +18
Lines 12659 15893 +3234
============================================
+ Hits 10229 13603 +3374
+ Misses 2430 2290 -140
Continue to review full report at Codecov.
|
Description
randomizetoExtraFieldsSerializerrandomized = true->randomized = falseIssue Addressed (if applicable)
Fixes #2864
Steps to Test