Check for $refs.editView before calling immediateSaveAll method#2950
Merged
marcellamaki merged 1 commit intoFeb 23, 2021
Merged
Conversation
marcellamaki
approved these changes
Feb 23, 2021
Member
marcellamaki
left a comment
marcellamaki
left a comment
There was a problem hiding this comment.
Looks good to me! Thanks for improving some code I worked on @jonboiser 😄
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The
handleClosemethod tries to call$refs.editView.immediateSaveAlleven though that ref is conditionally rendered. This simply checks to see if the ref exists before calling that method.Fixes #2949