Skip to content

First batch of gherkin scenarios#2911

Merged
radinamatic merged 6 commits into
learningequality:hotfixesfrom
metodimilevqa:gherkins
Feb 17, 2021
Merged

First batch of gherkin scenarios#2911
radinamatic merged 6 commits into
learningequality:hotfixesfrom
metodimilevqa:gherkins

Conversation

@metodimilevqa
Copy link
Copy Markdown

@metodimilevqa metodimilevqa commented Feb 5, 2021

Description

Migrating gherkin scenarios from Notion to GitHub.

Issue Addressed (if applicable)

...

Before/After Screenshots (if applicable)

...

Steps to Test

...

Implementation Notes (optional)

...

Checklist

Delete any items that don't apply

  • Is the code clean and well-commented?
  • Has the docs label been added if this introduces a change that needs to be updated in the user docs?
  • Has the CHANGELOG label been added to this pull request? Items with this label will be added to the CHANGELOG at a later time
  • Are there tests for this change?
  • Are all user-facing strings translated properly (if applicable)?
  • Has the notranslate class been added to elements that shouldn't be translated by Google Chrome's automatic translation feature (e.g. icons, user-generated text)?
  • Are all UI components LTR and RTL compliant (if applicable)?
  • Are views organized into pages, components, and layouts directories as described in the docs?
  • Are users' storage used being recalculated properly on any changes to their main tree files?
  • Are there any new ways this uses user data that needs to be factored into our Privacy Policy?
  • Are there any new interactions that need to be added to the QA Sheet?
  • Are there opportunities for using Google Analytics here (if applicable)?
  • If any Python requirements have changed, are the updated requirements.txt files also included in this PR?
  • Are the migrations safe for a large db (if applicable)?

Comments

...

Reviewers

If you are looking to assign a reviewer, here are some options:

  • Jordan jayoshih (full stack)
  • Aron aronasorman (back end, devops)
  • Micah micahscopes (full stack)
  • Kevin kollivier (back end)
  • Ivan ivanistheone (Ricecooker)
  • Richard rtibbles (full stack, Kolibri)
  • Radina @radinamatic (documentation)

@radinamatic radinamatic added the WIP label Feb 5, 2021
Comment thread integration_testing/features/cancelling-a-sync-operation.feature Outdated
Comment thread integration_testing/features/add-channel-to-starred- tab.feature Outdated
Comment thread integration_testing/features/cancelling-a-sync-operation.feature Outdated
Comment thread integration_testing/features/create-a-new-channel.feature Outdated
Comment thread integration_testing/features/cancelling-a-sync-operation.feature Outdated
Comment thread integration_testing/features/creating-a-new-topic.feature Outdated
Comment thread integration_testing/features/delete-account.feature Outdated
Comment thread integration_testing/features/delete-multiple-items-permanently.feature Outdated
Comment thread integration_testing/features/cancelling-the-copying-of-an-item.feature Outdated
Comment thread integration_testing/features/pressing-the-information-icon.feature Outdated
Comment thread integration_testing/features/add-channel-to-starred- tab.feature Outdated
Comment thread integration_testing/features/cancel-copy-of-multiple-selections.feature Outdated
Comment thread integration_testing/features/click-the-information-icon.feature Outdated
Comment thread integration_testing/features/cancel-copy-of-an-item.feature Outdated
Comment thread integration_testing/features/cancel-a-sync-operation.feature Outdated
Comment thread integration_testing/features/cancel-copy-of-multiple-selections.feature Outdated
Comment thread integration_testing/features/copy-multiple-selections.feature Outdated
Comment thread integration_testing/features/delete-multiple-items-permanently.feature Outdated
Comment thread integration_testing/features/finish-the-sync-operation.feature Outdated
Comment thread integration_testing/features/copy-resource-via-selection-bar.feature Outdated
Comment thread integration_testing/features/delete-resources.feature Outdated
Copy link
Copy Markdown
Member

@radinamatic radinamatic left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Excellent work, thank you! 💯

@radinamatic radinamatic removed the WIP label Feb 17, 2021
@radinamatic radinamatic merged commit c65e2d0 into learningequality:hotfixes Feb 17, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants