Skip to content

Ensure that dropped connections do not disrupt task execution or signal handling.#2848

Merged
rtibbles merged 4 commits into
learningequality:hotfixesfrom
rtibbles:interface_closed_for_tasks
Jan 21, 2021
Merged

Ensure that dropped connections do not disrupt task execution or signal handling.#2848
rtibbles merged 4 commits into
learningequality:hotfixesfrom
rtibbles:interface_closed_for_tasks

Conversation

@rtibbles
Copy link
Copy Markdown
Member

@rtibbles rtibbles commented Jan 21, 2021

Adds tests to replicate InterfaceError behaviour.
Adds fixes to ensure that connection is not expired during and after task execution

Fixes #2849

@rtibbles rtibbles requested a review from aronasorman January 21, 2021 02:46
@codecov
Copy link
Copy Markdown

codecov Bot commented Jan 21, 2021

Codecov Report

Merging #2848 (2bdad0e) into hotfixes (28587f8) will increase coverage by 4.07%.
The diff coverage is 88.73%.

Impacted file tree graph

@@             Coverage Diff              @@
##           hotfixes    #2848      +/-   ##
============================================
+ Coverage     80.80%   84.87%   +4.07%     
============================================
  Files           281      292      +11     
  Lines         12659    15407    +2748     
============================================
+ Hits          10229    13077    +2848     
+ Misses         2430     2330     -100     
Impacted Files Coverage Δ
contentcuration/contentcuration/decorators.py 56.60% <50.00%> (-37.60%) ⬇️
contentcuration/contentcuration/forms.py 69.06% <72.41%> (+20.61%) ⬆️
...ntentcuration/contentcuration/db/models/manager.py 93.49% <93.33%> (-6.51%) ⬇️
contentcuration/contentcuration/api.py 92.06% <100.00%> (+1.43%) ⬆️
...tentcuration/contentcuration/context_processors.py 100.00% <100.00%> (ø)
...tcuration/contentcuration/db/models/expressions.py 93.33% <100.00%> (-6.67%) ⬇️
...entcuration/contentcuration/db/models/functions.py 100.00% <100.00%> (ø)
...ation/contentcuration/tests/test_rest_framework.py 36.93% <0.00%> (-63.07%) ⬇️
contentcuration/contentcuration/utils/format.py 21.05% <0.00%> (-49.54%) ⬇️
contentcuration/contentcuration/utils/cache.py 31.70% <0.00%> (-31.93%) ⬇️
... and 174 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update b73cee1...2bdad0e. Read the comment docs.

Comment thread contentcuration/contentcuration/utils/celery_signals.py Outdated
Copy link
Copy Markdown
Collaborator

@aronasorman aronasorman left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Some questions

Comment thread contentcuration/contentcuration/utils/celery_signals.py Outdated
Comment thread contentcuration/contentcuration/utils/celery_signals.py Outdated
@rtibbles rtibbles merged commit fe73455 into learningequality:hotfixes Jan 21, 2021
@rtibbles rtibbles deleted the interface_closed_for_tasks branch January 21, 2021 17:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

InterfaceError: connection already closed

2 participants