Channel modal toggle routing#2547
Conversation
Codecov Report
@@ Coverage Diff @@
## develop #2547 +/- ##
========================================
Coverage 84.65% 84.66%
========================================
Files 296 296
Lines 15011 15007 -4
========================================
- Hits 12708 12705 -3
+ Misses 2303 2302 -1
Continue to review full report at Codecov.
|
Retain channel list type between browsing/reviewing/searching in import modal
Throw a big error if try to move a child to be its own parent
MisRob
left a comment
MisRob
left a comment
There was a problem hiding this comment.
Thank you, @marcellamaki.
The code looks good. I manually tested the page, and everything is working very well except for one issue:
- Click "Edit channel details" (that takes you to "Details" tab of the channel modal page)
- Navigate to "Sharing" tab
- Close the modal
- Click "Edit channel details" again
"Sharing" tab is open
Expected
"Details" tab is open
This is happening from both channel list and channel editor pages.
I think I will need to make some modifications with my strings, as there are some place where I am using specific values for the tab param (i.e. "Share" and "Edit). I am considering using values that are already available, so that strings don't need to be added - perhaps the same as the tab names (details and sharing)? I would appreciate any recommendations here or elsewhere in the changes.
I believe that we only need to be concerned about adding new user-facing strings for translations, and those that you've added don't seem so, is that right?
We now use the simpler API
Makes production creds much simpler to manage
…k-sheets Use GOOGLE_APPLICATION_CREDENTIALS as the auth mechanism for connecting to sheets
Load search results on first entry
…r-and-ar Latest French and Arabic i18n
Better error handling in change event handlers
…nnelsetlist-by-user Filter channelsetlist by user
…pen-in-order Make sure changes are merged in order
…pen-in-order Correctly order changes when looking for the last change
…ent-item-ordering-arrows Fix assessment item reordering
…_paginate_admin_channels annotate after paginate Admin channels and users
Being more semantic when annotate after paginate is used
…pen-in-order Ensure changes are merged in order, log an error if not.
…-in-window.urls Ensure window.Urls has correct language code & browser lang is respected
Optimize catalog filters and pagination
…refactor to use props rather than refer directly to route
…to channel-modal-toggle-routing
|
Superseded by #2643 |
12 participants
Please remove any unused sections
Description
Updates routing to use params rather than the query sharing=true in the share and detail modal, and make sure the tab indicator aligns with "share" correctly on open.
Issue Addressed (if applicable)
Addresses #2004
Before/After Screenshots (if applicable)
Steps to Test
Option 1:
Option 2:
Comments
This is a WIP and while it does seem to be working, I think I will need to make some modifications with my strings, as there are some place where I am using specific values for the tab param (i.e. "Share" and "Edit). I am considering using values that are already available, so that strings don't need to be added - perhaps the same as the tab names (details and sharing)? I would appreciate any recommendations here or elsewhere in the changes.